Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev: import alexandria as local crate #566

Merged
merged 2 commits into from
Nov 22, 2023
Merged

dev: import alexandria as local crate #566

merged 2 commits into from
Nov 22, 2023

Conversation

enitrat
Copy link
Collaborator

@enitrat enitrat commented Nov 22, 2023

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Resolves: #

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Eikix
Eikix approved these changes Nov 22, 2023
View reviewed changes
Copy link
Member

@Eikix Eikix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@enitrat enitrat added this pull request to the merge queue Nov 22, 2023
Merged via the queue into main with commit 6262325 Nov 22, 2023
4 checks passed
@enitrat enitrat deleted the dev/inline-alexandria branch November 22, 2023 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eikix Eikix Eikix approved these changes

@ClementWalter ClementWalter Awaiting requested review from ClementWalter ClementWalter is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@enitrat @Eikix